CUST-4111/CUST-4162: improve to more descriptive error response & validate event's start vs end time #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googsvg
changed the title
Contributor
Author
|
This PR will cover two tickets: https://nylas.atlassian.net/browse/CUST-4162 → automatically also more descriptive error response when API error response cannot be parsed |
googsvg
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
googsvg
commented
Jan 21, 2026
AaronDDM
reviewed
Jan 21, 2026
Add test case for the scenario where API returns valid JSON but the error object parses to null, triggering the final fallback error message path in NylasClient. This improves test coverage for the enhanced error handling introduced in the previous commit. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
googsvg
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
reviewed
Jan 26, 2026
AaronDDM
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.